Adding Express Lane flag to Traffic#1831
Conversation
- Adding optional flag to identify whether Traffic Flow or Incident information is related to a HOV (High Occupancy Vehicle) linear. (https://en.wikipedia.org/wiki/High-occupancy_vehicle_lane)
| * `is_bridge`: set to `true` when the linear is a bridge | ||
| * `is_tunnel`: set to `true` when the linear is a tunnel | ||
| * `is_link`: set to true when the linear is a slip-road | ||
| * `is_express_lane`: set to `true` when the linear is an HOV (High-Occupancy Vechicle) lane. |
There was a problem hiding this comment.
Why is this necessary, can you explain your rational with an example, please?
We currently don't include hov tags on the roads layer features, so seems slightly odd to include it here in the traffic_flow and traffic_incidents layers. While there has been discussion to add lane tags into the tiles, and then hov could be added as part of that, I'm still not sure why it's necessary – except for HD mapping, which Tilezen currently isn't really geared for.
If we were to do this...
The OSM-ism we'd follow is hov instead of express, please say is_hov instead.
See also:
Visually would you sort the HOV traffic over the non-HOV traffic flow lines? Would you want a way to turn off the non-HOV traffic lines? This starts to get tricky fast.
There was a problem hiding this comment.
Hi Nathaniel,
I got confused (I'm British/Irish) and misunderstood what an Express Lane is. So updating the patch with a new commit for the explanations.
However this still won't satisfy this comment:
While there has been discussion to add lane tags into the tiles, and then hov could be added as part of that, I'm still not sure why it's necessary – except for HD mapping, which Tilezen currently isn't really geared for.
Indeed this is lane-specific information, but basically we'd like to be able to have this tag so that the client is aware that the Traffic Flow/Incident information is affecting the Express Lane on a particular road.
| * `is_tunnel`: set to `true` when the linear is a tunnel | ||
| * `is_link`: set to true when the linear is a slip-road | ||
| * `drives_on_left`: set to `true` when the country drives on the left, e.g. In the U.K | ||
| * `is_express_lane`: set to `true` when the linear is an HOV (High-Occupancy Vechicle) lane. |
There was a problem hiding this comment.
See above, would be is_hov.
But please explain why HOV tag is needed here at all. Plus we're talking about points here, right? So the comment would also need to update.
- Misunderstood HOV vs Express Lane. Updating comments.
nvkelso
left a comment
There was a problem hiding this comment.
I updated this to the OSM-ism is_hov_lane, reworded the docs, and LGTM for merging.
|
@conor-ettinoffe-here I remember seeing followup about this over the weekend, but I can't find now. Can you summarize with a comment here, please? |
Hi Nathaniel, its okay no longer a point :) I basically was saying I meant Express Lane and not HOV - however according to OSM HOV is a synonym of express lane:
So all is clear now. Thanks! |
|
Okay, sounds good! I agree it's a little confusing, but all is well that ends well :) |
Uh oh!
There was an error while loading. Please reload this page.