feat(acp): support /mcp slash command in ACP mode#395
Merged
Conversation
Previously Op::ListMcpTools was unsupported in the ACP backend, causing /mcp to silently fail when MCP servers were configured. This adds handling by threading mcp_servers config through AcpBackendConfig, computing auth statuses locally, and returning McpListToolsResponseEvent with server details. Also fixes the TUI rendering to show server config even when individual tool names are unavailable (as in ACP mode where the upstream agent manages MCP connections). 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Nori
Op::ListMcpToolsin the ACP backend — previously this was unsupported, causing/mcpto silently fail when MCP servers were configuredAcpBackendConfigintoAcpBackend, computes auth statuses locally viacompute_auth_statuses()Test Plan
/mcpwith configured servers shows server name, header, and command/mcpwith no servers shows "No MCP servers configured"Share Nori with your team: https://www.npmjs.com/package/nori-skillsets