Skip to content

fix(acp): Show patch more consistently with rendering fallback#392

Merged
CSRessel merged 2 commits intomainfrom
fix/transcript-viewer-history-truncation
Mar 24, 2026
Merged

fix(acp): Show patch more consistently with rendering fallback#392
CSRessel merged 2 commits intomainfrom
fix/transcript-viewer-history-truncation

Conversation

@CSRessel
Copy link
Copy Markdown
Collaborator

@CSRessel CSRessel commented Mar 24, 2026

Summary

🤖 Generated with Nori

  • keep late-resolved ACP edit/write completions on the patch path so the live transcript viewer renders the same diff-style patch block instead of an exec-style Edit(path) cell
  • reuse the same completion-resolution logic for transcript recording so persisted transcript shape stays aligned with the live UI path
  • add ACP regression coverage for the completion fallback and document the updated ACP/TUI behavior

Test Plan

  • just fmt
  • just fix -p codex-acp
  • cargo test -p codex-acp
  • cargo test -p nori-tui apply_patch_events_emit_history_cells
  • cargo test -p nori-tui transcript_overlay_keeps_patch_cells_untruncated
  • cargo build --bin nori
  • cargo test -p tui-pty-e2e

Share Nori with your team: https://www.npmjs.com/package/nori-skillsets

@CSRessel CSRessel changed the title Truncate transcript overlay history cells Fix ACP transcript patch rendering fallback Mar 24, 2026
@CSRessel CSRessel changed the title Fix ACP transcript patch rendering fallback fix(acp): Show patch more consistently with rendering fallback Mar 24, 2026
@CSRessel CSRessel merged commit cedf71a into main Mar 24, 2026
3 checks passed
@CSRessel CSRessel deleted the fix/transcript-viewer-history-truncation branch March 24, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant