refactor(tui): remove HTTP backend fallback path#388
Merged
Conversation
The TUI had a dead HTTP backend fallback via `spawn_http_agent()` and `ConversationManager` that was never exercised (acp_allow_http_fallback defaults to false). Since nori exclusively uses the ACP backend, this removes the entire HTTP fallback code path: - Remove spawn_http_agent(), spawn_agent_from_existing() from agent.rs - Remove ConversationManager parameter threading through spawn_agent(), ChatWidget::new(), and spawn_deferred_agent() - Delete ChatWidget::new_from_existing() (HTTP-backend fork/resume) - Remove server/server_for_deferred_spawn fields from App struct - Replace HTTP fork in app_backtrack with ACP-friendly fork_context - Make shutdown_current_conversation() synchronous - Delete dead files: config_summary.rs, client_acp_tests.rs - Add deferred_spawn_pending guard to prevent agent duplication - Log warning when startup --resume is used (unsupported with ACP) 🤖 Generated with [Nori](https://nori.ai) Co-Authored-By: Nori <contact@tilework.tech> 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
…connection-after-expiry-20260320-200820 # Conflicts: # codex-rs/tui/src/chatwidget/constructors.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the dead HTTP backend fallback code from the TUI. Nori exclusively uses the ACP backend, but the TUI retained an HTTP fallback path (
spawn_http_agent,ConversationManager) that was never exercised in practice (acp_allow_http_fallbackdefaults to false).spawn_http_agent(),spawn_agent_from_existing(), andConversationManagerparameter threading throughout the TUIapp_backtrack.rswith ACP-friendlyfork_contextapproachconfig_summary.rs(never called),client_acp_tests.rs(never compiled)deferred_spawn_pendingguard to prevent agent duplication during mid-session skillset switches--resumeis used (not supported with ACP; use in-session/resumeinstead)Net: ~420 lines removed across 14 files.
🤖 Generated with Nori
Co-Authored-By: Nori contact@tilework.tech
Test plan
cargo test -p nori-tui— 993 tests passcargo test -p tui-pty-e2e— 36 tests pass (31 run + 5 ignored)just fix -p nori-tui— no clippy warningscargo build --bin nori— compiles cleanly/resumein-session works