Skip to content

feat(tui): add vim-mode-aware search to skillset picker#382

Merged
theahura merged 1 commit intomainfrom
auto/safe-gem-20260316-184606
Mar 16, 2026
Merged

feat(tui): add vim-mode-aware search to skillset picker#382
theahura merged 1 commit intomainfrom
auto/safe-gem-20260316-184606

Conversation

@theahura
Copy link
Copy Markdown
Contributor

Summary

🤖 Generated with Nori

  • Enable type-to-filter search on the skillset picker modal and all searchable ListSelectionView instances
  • Vim mode ON: j/k navigate, / activates search input, digits 1-9 direct-select, Esc exits search without dismissing
  • Vim mode OFF: typing immediately filters the list, arrows navigate
  • BottomPane automatically injects vim mode into all searchable selection views so individual callers don't need to manage it

Test Plan

  • 8 new unit tests covering vim/non-vim searchable key handling
  • All 1000 existing nori-tui tests pass
  • Clippy clean
  • Manual test: open skillset picker with vim mode on, verify j/k navigate and / activates search
  • Manual test: open skillset picker with vim mode off, verify typing filters immediately

Share Nori with your team: https://www.npmjs.com/package/nori-skillsets

…tionView

Enable type-to-filter on the skillset picker modal. When vim mode is off,
typing immediately filters the list. When vim mode is on, j/k navigate,
/ activates search, and Esc exits search without dismissing the popup.
BottomPane automatically injects vim_mode into all searchable selection views.
🤖 Generated with [Nori](https://usenori.ai)

Co-Authored-By: Nori <contact@tilework.tech>
@theahura theahura merged commit ceb13d0 into main Mar 16, 2026
3 checks passed
@theahura theahura deleted the auto/safe-gem-20260316-184606 branch March 16, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant