fix(acp): populate formatted_output for transcript viewer#378
Merged
Conversation
ACP tool call events were setting formatted_output to an empty string in ExecCommandEndEvent, causing tool outputs to appear blank in the transcript viewer which reads from that field. 🤖 Generated with [Nori](https://usenori.ai) Co-Authored-By: Nori <contact@tilework.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Nori
formatted_outputto an empty string inExecCommandEndEvent, causing tool outputs to appear blank in the transcript viewer (which readsformatted_outputattui/src/exec_cell/render.rs:222)formatted_output = aggregated_output.clone()so the transcript viewer displays the same output shown inlineformatted_outputmatchesaggregated_outputfor ACP tool callsTest Plan
cargo test -p codex-acp— all 16 tests passjust fix -p codex-acp— clippy cleanShare Nori with your team: https://www.npmjs.com/package/nori-ai