Skip to content

sst_importer: skip validation in ingest temporary (#7415)#7632

Merged
sre-bot merged 7 commits intotikv:release-4.0from
3pointer:release-4.0
Apr 29, 2020
Merged

sst_importer: skip validation in ingest temporary (#7415)#7632
sre-bot merged 7 commits intotikv:release-4.0from
3pointer:release-4.0

Conversation

@3pointer
Copy link
Contributor

cherry-pick #7415 to release-4.0


What problem does this PR solve?

Issue Number: close pingcap/br#163

Problem Summary:

  • when we perform rewrite in download sst, the length of sstMeta will change, so it will cause panic in next vaildation.

What is changed and how it works?

This PR skip validation before ingest sst, so we can avoid panic since file length doesn't match.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

bugfixes: Fix the issue that generate lots of empty region after restore.

… sst file size correctly (tikv#7415)

Signed-off-by: luancheng <luancheng@pingcap.com>
@3pointer 3pointer requested a review from kennytm April 23, 2020 07:02
@kennytm
Copy link
Contributor

kennytm commented Apr 23, 2020

/run-all-tests

@3pointer 3pointer added component/backup-restore Component: backup, import, external_storage status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. type/cherry-pick Type: PR - Cherry pick labels Apr 24, 2020
@3pointer 3pointer requested a review from overvenus April 24, 2020 05:22
@3pointer 3pointer added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Apr 24, 2020
@BusyJay BusyJay added this to the v4.0.0 milestone Apr 25, 2020
@kennytm kennytm added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 26, 2020
@overvenus
Copy link
Member

/run-integration-br-test

@glorv
Copy link
Contributor

glorv commented Apr 29, 2020

/run-all-tests

@hicqu
Copy link
Contributor

hicqu commented Apr 29, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 29, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 29, 2020

/run-all-tests

@sre-bot sre-bot merged commit 907ba02 into tikv:release-4.0 Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/backup-restore Component: backup, import, external_storage priority/release-blocker This issue blocks a release. Please solve it ASAP. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick Type: PR - Cherry pick

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants