[DNM] raftstore: change the split flow path#7503
Closed
gengliqi wants to merge 1 commit intotikv:masterfrom
Closed
[DNM] raftstore: change the split flow path#7503gengliqi wants to merge 1 commit intotikv:masterfrom
gengliqi wants to merge 1 commit intotikv:masterfrom
Conversation
Signed-off-by: Liqi Geng <gengliqiii@gmail.com>
cfba53f to
d0199cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Liqi Geng gengliqiii@gmail.com
What problem does this PR solve?
Problem Summary:
The new region which is created by splitting may has already created before in some sophisticated cases.
So we must change the split flow path to check whether it should be created.
Add a new key
region_temp_stateto transition from one temporary state to the normal state if it can be created.It's still in progress. (There are some details need to think twice and the tests have not been written yet. It needs many tests to make this PR reliable.)
What is changed and how it works?
Change the split path
What's Changed:
Related changes
Check List
Tests
Side effects
The time of creating a new peer by splitting will be longer than before but I think it's fine and I will test it.
Release note