Skip to content

br: add content length for multi part upload (#19358)#19376

Open
ti-chi-bot wants to merge 5 commits intotikv:release-8.1from
ti-chi-bot:cherry-pick-19358-to-release-8.1
Open

br: add content length for multi part upload (#19358)#19376
ti-chi-bot wants to merge 5 commits intotikv:release-8.1from
ti-chi-bot:cherry-pick-19358-to-release-8.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Feb 15, 2026

This is an automated cherry-pick of #19358

What is changed and how it works?

Issue Number: Close #19352

What's Changed:

add Content-Length into HTTP Request Header to make it compatible with GCP S3 compatible service.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

Summary by CodeRabbit

  • Bug Fixes

    • Improved S3 multipart upload behavior so multipart uploads, completes, and aborts include correct HTTP length handling, reducing multipart upload errors.

  • Tests

    • Added tests covering multipart abort flows and updated tests for multipart uploads.
    • Adjusted timing metric tests to verify upload-part histogram behavior and ensure reliable histogram tracking.

@Leavrth @ti-chi-bot
draft
d8d8a4d 
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@Leavrth @ti-chi-bot
add unit tests
ff75fd9 
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@Leavrth @ti-chi-bot
fix typos
02cc6ad 
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@Leavrth @ti-chi-bot
make clippy
8878e84 
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@Leavrth @ti-chi-bot
fix unit test
4197725 
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Feb 15, 2026
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 15, 2026
Merged
9 tasks
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 15, 2026

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be LGTMed and approved by the reviewers firstly.
  2. For pull requests to TiDB-x branches, it must have no failed tests.
  3. AFTER it has lgtm and approved labels, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai
Copy link

coderabbitai bot commented Feb 15, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign busyjay for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 15, 2026

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-check-deps 4197725 link true /test pull-check-deps
pull-unit-test 4197725 link true /test pull-unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Leavrth Leavrth

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ti-chi-bot @Leavrth