Skip to content

br: add content length for multi part upload (#19358)#19375

Merged
ti-chi-bot[bot] merged 5 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-19358-to-release-8.5
Mar 5, 2026
Merged

br: add content length for multi part upload (#19358)#19375
ti-chi-bot[bot] merged 5 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-19358-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Feb 15, 2026

This is an automated cherry-pick of #19358

What is changed and how it works?

Issue Number: Close #19352

What's Changed:

add Content-Length into HTTP Request Header to make it compatible with GCP S3 compatible service.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

Summary by CodeRabbit

  • Bug Fixes

    • Improved S3 multipart upload behavior so multipart uploads, completes, and aborts include correct HTTP length handling, reducing multipart upload errors.

  • Tests

    • Added tests covering multipart abort flows and updated tests for multipart uploads.
    • Adjusted timing metric tests to verify upload-part histogram behavior and ensure reliable histogram tracking.

@Leavrth @ti-chi-bot
draft
2d255e8 
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@Leavrth @ti-chi-bot
add unit tests
329a738 
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@Leavrth @ti-chi-bot
fix typos
d2b79da 
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@Leavrth @ti-chi-bot
make clippy
6061672 
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@Leavrth @ti-chi-bot
fix unit test
29d06a3 
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Feb 15, 2026
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 15, 2026
Merged
9 tasks
@coderabbitai
Copy link

coderabbitai bot commented Feb 15, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 2, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: v01dstar, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 2, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 2, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-03-02 02:58:55.87779316 +0000 UTC m=+154180.455872354: ☑️ agreed by YuJuncen.
  • 2026-03-02 09:22:08.690707205 +0000 UTC m=+177173.268786389: ☑️ agreed by v01dstar.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Mar 2, 2026
@Leavrth
Copy link
Contributor

Leavrth commented Mar 5, 2026

/retest

@ti-chi-bot ti-chi-bot bot merged commit 5487a8e into tikv:release-8.5 Mar 5, 2026
6 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-19358-to-release-8.5 branch March 5, 2026 04:07
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 5, 2026

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test 29d06a3 link unknown /test pull-unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@v01dstar v01dstar v01dstar approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

Assignees

@Leavrth Leavrth

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @Leavrth @v01dstar @YuJuncen