Skip to content

sst_importer: ensure cleanup of temporary files on error (#19240)#19256

Merged
ti-chi-bot[bot] merged 4 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-19240-to-release-8.5
Jan 7, 2026
Merged

sst_importer: ensure cleanup of temporary files on error (#19240)#19256
ti-chi-bot[bot] merged 4 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-19240-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 31, 2025

This is an automated cherry-pick of #19240

What is changed and how it works?

Issue Number: ref #17283, Close #19239

What's Changed:

sst_importer: enhance failpoint handling and ensure cleanup of temporary files on error

- Ensure temporary files are cleaned up when a download fails in sst_importer
- Add a new failpoint `download_files_ext_after_download` to inject errors right after batch downloads complete, improving test coverage of cleanup paths

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test (extends tests to verify temporary files and encryption metadata are cleaned up)
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fix a bug where temporary SST files could be left behind when a download failed in sst_importer.

…ary files on error

Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Dec 31, 2025
@EmmaDuDu
Copy link

EmmaDuDu commented Jan 5, 2026

/retest

Signed-off-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 5, 2026
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 7, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 7, 2026

@YuJuncen: Your lgtm message is repeated, so it is ignored.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 7, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 7, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-01-07 04:02:36.043931594 +0000 UTC m=+761311.862240026: ☑️ agreed by YuJuncen.
  • 2026-01-07 04:46:00.052302463 +0000 UTC m=+763915.870610894: ☑️ agreed by Leavrth.

@ti-chi-bot ti-chi-bot bot merged commit 9469bff into tikv:release-8.5 Jan 7, 2026
5 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-19240-to-release-8.5 branch January 7, 2026 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants