Skip to content

coprocessor: fix the indexlookup push down local lookup range may exceeds the region end (#19216)#19218

Merged
ti-chi-bot[bot] merged 2 commits intotikv:release-8.5from
lcwangchao:cherry-pick-19216-to-release-8.5-2
Dec 17, 2025
Merged

coprocessor: fix the indexlookup push down local lookup range may exceeds the region end (#19216)#19218
ti-chi-bot[bot] merged 2 commits intotikv:release-8.5from
lcwangchao:cherry-pick-19216-to-release-8.5-2

Conversation

@lcwangchao
Copy link
Contributor

@lcwangchao lcwangchao commented Dec 17, 2025

This is an cherry-pick of #19216

What is changed and how it works?

Issue Number: Close #19215

What's Changed:

The int handle will use the `convert_to_prefix_next` as the end of the point-get range. However, the prefix next may exceeds the region end. In the previous implementation, at this time we use the region end as the table scan range end. However, the region range end is in MVCC format, we must decode it to raw format first.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@lcwangchao @ti-chi-bot
coprocessor: fix the indexlookup push down local lookup range may exc…
a4e4fbb 
…eeds the region end

Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
@lcwangchao
fix lint
8a9e16c 
Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Dec 17, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 17, 2025

Hi @lcwangchao. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 17, 2025
@lcwangchao lcwangchao mentioned this pull request Dec 17, 2025
Closed
9 tasks
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 17, 2025
@cfzjywxk
Copy link
Collaborator

cfzjywxk commented Dec 17, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. cherry-pick-approved Cherry pick PR approved by release team. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. do-not-merge/cherry-pick-not-approved labels Dec 17, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 17, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 17, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-17 09:32:01.910505405 +0000 UTC m=+1638266.724282967: ☑️ agreed by lhy1024.
  • 2025-12-17 09:43:46.76616037 +0000 UTC m=+1638971.579937952: ☑️ agreed by cfzjywxk.

@lcwangchao
Copy link
Contributor Author

lcwangchao commented Dec 17, 2025

/retest

1 similar comment
@lhy1024
Copy link
Contributor

lhy1024 commented Dec 17, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit d84cdc1 into tikv:release-8.5 Dec 17, 2025
5 checks passed
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 17, 2025

@lcwangchao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test 8a9e16c link unknown /test pull-unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lcwangchao lcwangchao deleted the cherry-pick-19216-to-release-8.5-2 branch December 17, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

+1 more reviewer

@lhy1024 lhy1024 lhy1024 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lcwangchao @cfzjywxk @lhy1024