Skip to content

raftstore: reset region approximate size/keys stats when it becomes leader (#19181)#19186

Merged
glorv merged 1 commit intotikv:release-8.5-20251208-v8.5.4from
glorv:cp-19185
Dec 8, 2025
Merged

raftstore: reset region approximate size/keys stats when it becomes leader (#19181)#19186
glorv merged 1 commit intotikv:release-8.5-20251208-v8.5.4from
glorv:cp-19185

Conversation

@glorv
Copy link
Contributor

@glorv glorv commented Dec 8, 2025 •
edited
Loading

What is changed and how it works?

Issue Number: Close #19180

What's Changed:

Reset region's approximate size/keys stats when peer becomes leader. This can avoid peer report outdated stats to pd and caused unnecessary balance scheduling.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@glorv
raftstore: reset region approximate size/keys stats when it becomes l…
15c82ba 
…eader (tikv#19181)

close tikv#19180

Reset region's approximate size/keys stats when peer becomes leader. This can avoid peer report outdated stats to pd and caused unnecessary balance scheduling.

Signed-off-by: glorv <glorvs@163.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 8, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 8, 2025

@hhwyt: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 8, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-08 13:40:51.797856464 +0000 UTC m=+875596.611634026: ☑️ agreed by hbisheng.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 8, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hbisheng, hhwyt
Once this PR has been reviewed and has the lgtm label, please assign andremouche for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@glorv glorv merged commit e5fa294 into tikv:release-8.5-20251208-v8.5.4 Dec 8, 2025
3 of 4 checks passed
@glorv glorv deleted the cp-19185 branch December 8, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@hbisheng hbisheng hbisheng approved these changes

@hhwyt hhwyt hhwyt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@glorv @hbisheng @hhwyt