Skip to content

raftstore: reset region approximate size/keys stats when it becomes leader (#19181)#19184

Open
ti-chi-bot wants to merge 3 commits intotikv:release-7.5from
ti-chi-bot:cherry-pick-19181-to-release-7.5
Open

raftstore: reset region approximate size/keys stats when it becomes leader (#19181)#19184
ti-chi-bot wants to merge 3 commits intotikv:release-7.5from
ti-chi-bot:cherry-pick-19181-to-release-7.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 8, 2025

This is an automated cherry-pick of #19181

What is changed and how it works?

Issue Number: Close #19180

What's Changed:

Reset region's approximate size/keys stats when peer becomes leader. This can avoid peer report outdated stats to pd and caused unnecessary balance scheduling.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fix the bug that pd heartbeat may report wrong region size/keys statistics data after leader change.

glorv added 3 commits December 8, 2025 13:09
@glorv @ti-chi-bot
reset region approximate size/keys stats when it becomes leader
e9ead75 
Signed-off-by: glorv <glorvs@163.com>
@glorv @ti-chi-bot
add comment
c747040 
Signed-off-by: glorv <glorvs@163.com>
@glorv @ti-chi-bot
fix test
88c9388 
Signed-off-by: glorv <glorvs@163.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Dec 8, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 8, 2025
Merged
9 tasks
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 8, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign 5kbpers for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@glorv glorv

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ti-chi-bot @glorv