Skip to content

server: graceful shutdown tikv-impl (#18930)#19157

Merged
ti-chi-bot[bot] merged 5 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-18930-to-release-8.5
Dec 4, 2025
Merged

server: graceful shutdown tikv-impl (#18930)#19157
ti-chi-bot[bot] merged 5 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-18930-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 1, 2025

This is an automated cherry-pick of #18930

What is changed and how it works?

Issue Number: Close #17221

What's Changed:

When a SIGTERM signal is received, TiKV tells PD it's stopping by StoreHeartbeat. PD then try to move all the leaders from that TiKV instance before it fully shuts down.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Support graceful shutdown for TiKV upon receiving a SIGTERM signal.

@hujiatao0 @ti-chi-bot
This is an automated cherry-pick of tikv#18930
4d31b3c 
close tikv#17221

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 1, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 1, 2025
Merged
9 tasks
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Dec 1, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 1, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 3, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 3, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-01 05:20:44.439470005 +0000 UTC m=+240789.253247567: ☑️ agreed by overvenus.
  • 2025-12-03 03:58:14.294135937 +0000 UTC m=+408639.107913519: ☑️ agreed by hbisheng.

@hbisheng
Copy link
Member

hbisheng commented Dec 3, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Dec 3, 2025
@LykxSassinator
Copy link
Contributor

LykxSassinator commented Dec 4, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2025
zhangjinpeng87
zhangjinpeng87 approved these changes Dec 4, 2025
View reviewed changes
Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbisheng, overvenus, zhangjinpeng87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 4, 2025
@ti-chi-bot ti-chi-bot bot merged commit e978675 into tikv:release-8.5 Dec 4, 2025
5 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-18930-to-release-8.5 branch December 4, 2025 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overvenus overvenus overvenus approved these changes

@zhangjinpeng87 zhangjinpeng87 zhangjinpeng87 approved these changes

+1 more reviewer

@hbisheng hbisheng hbisheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-chi-bot @hbisheng @LykxSassinator @overvenus @zhangjinpeng87 @hujiatao0