Skip to content

Add grpc wait duration metrics (#18810)#18826

Merged
ti-chi-bot[bot] merged 1 commit intotikv:release-8.5from
ti-chi-bot:cherry-pick-18810-to-release-8.5
Nov 11, 2025
Merged

Add grpc wait duration metrics (#18810)#18826
ti-chi-bot[bot] merged 1 commit intotikv:release-8.5from
ti-chi-bot:cherry-pick-18810-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #18810

What is changed and how it works?

Issue Number: Close #18809

What's Changed:


Set "server.grpc-compression-type: gzip" and read large row data to overload grpc thread.
When gRPC thread is overloading, we can see "RPC Layer Latency" is high:
img_v3_02p2_f804792c-cdc0-4a55-be82-9cf9ca8368ag

After adding grpc wait metrics, we can further detect the root cause and detect it earlier:
img_v3_02p2_e771189c-a335-43aa-b879-a6c2cab3abbg

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Aug 13, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 13, 2025
9 tasks
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 13, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 13, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 13, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-13 06:41:42.702071289 +0000 UTC m=+422501.736654517: ☑️ agreed by glorv.
  • 2025-08-13 07:01:39.52784638 +0000 UTC m=+423698.562429618: ☑️ agreed by MyonKeminta.

Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, MyonKeminta, zhangjinpeng87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [MyonKeminta,glorv,zhangjinpeng87]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yibin87 yibin87 force-pushed the cherry-pick-18810-to-release-8.5 branch from 3382a0b to 41c5a88 Compare November 10, 2025 11:16
Signed-off-by: yibin87 <huyibin@pingcap.com>
@yibin87 yibin87 force-pushed the cherry-pick-18810-to-release-8.5 branch from 41c5a88 to 006d68e Compare November 10, 2025 11:19
@yibin87
Copy link
Contributor

yibin87 commented Nov 10, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2025
@yibin87
Copy link
Contributor

yibin87 commented Nov 10, 2025

/test pull-unit-test

1 similar comment
@yibin87
Copy link
Contributor

yibin87 commented Nov 10, 2025

/test pull-unit-test

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 11, 2025
@ti-chi-bot ti-chi-bot bot merged commit 7d661d2 into tikv:release-8.5 Nov 11, 2025
5 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-18810-to-release-8.5 branch November 11, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants