Skip to content

Add grpc wait duration metrics (#18810)#18825

Open
ti-chi-bot wants to merge 1 commit intotikv:release-8.1from
ti-chi-bot:cherry-pick-18810-to-release-8.1
Open

Add grpc wait duration metrics (#18810)#18825
ti-chi-bot wants to merge 1 commit intotikv:release-8.1from
ti-chi-bot:cherry-pick-18810-to-release-8.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Aug 13, 2025

This is an automated cherry-pick of #18810

What is changed and how it works?

Issue Number: Close #18809

What's Changed:

Set "server.grpc-compression-type: gzip" and read large row data to overload grpc thread.
When gRPC thread is overloading, we can see "RPC Layer Latency" is high:
img_v3_02p2_f804792c-cdc0-4a55-be82-9cf9ca8368ag

After adding grpc wait metrics, we can further detect the root cause and detect it earlier:
img_v3_02p2_e771189c-a335-43aa-b879-a6c2cab3abbg

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@yibin87 @ti-chi-bot
This is an automated cherry-pick of tikv#18810
55b4481 
close tikv#18809

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 13, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 13, 2025
Merged
9 tasks
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. label Aug 13, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 13, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ninglin-p for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yibin87
Copy link
Contributor

yibin87 commented Aug 13, 2025

/close

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 13, 2025

@yibin87: You can't close an active issue/PR unless you authored it or you are a collaborator.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 16, 2025

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test 55b4481 link true /test pull-unit-test
pull-check-deps 55b4481 link true /test pull-check-deps

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/cherry-pick-not-approved do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ti-chi-bot @yibin87