Skip to content

collation: fix wrong compare result for unicode collate (#18785)#18791

Merged
ti-chi-bot[bot] merged 2 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-18785-to-release-8.5
Aug 8, 2025
Merged

collation: fix wrong compare result for unicode collate (#18785)#18791
ti-chi-bot[bot] merged 2 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-18785-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Aug 5, 2025

This is an automated cherry-pick of #18785

What is changed and how it works?

Issue Number: Close #18784

What's Changed:

Follow tidb code, see https://github.com/pingcap/tidb/blob/2a522358ceb60095eea898503682595dd3612492/pkg/util/collate/ucaimpl/unicode_ci.go.tpl#L50 to get more informations.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@Defined2014 @ti-chi-bot
collation: fix wrong compare result for unicode collate
a55e4f5 
Signed-off-by: mohangjie <mohangjie1995@gmail.com>
@Defined2014 @ti-chi-bot
update
da65c49 
Signed-off-by: mohangjie <mohangjie1995@gmail.com>

update

Signed-off-by: mohangjie <mohangjie1995@gmail.com>
@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Aug 5, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 5, 2025
Merged
9 tasks
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 6, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 6, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 6, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-06 02:01:11.130796399 +0000 UTC m=+406381.273557574: ☑️ agreed by breezewish.
  • 2025-08-06 03:12:39.360157539 +0000 UTC m=+410669.502918714: ☑️ agreed by overvenus.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breezewish, overvenus, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [breezewish,overvenus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Defined2014
Copy link
Contributor

Defined2014 commented Aug 7, 2025

/retest

1 similar comment
@Defined2014
Copy link
Contributor

Defined2014 commented Aug 7, 2025

/retest

@Defined2014
Copy link
Contributor

Defined2014 commented Aug 8, 2025

/test pull-unit-test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 8, 2025

@Defined2014: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-unit-test

Use /test all to run all jobs.

Details

In response to this:

/test pull-unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014
Copy link
Contributor

Defined2014 commented Aug 8, 2025

/test all

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 8, 2025
@ti-chi-bot ti-chi-bot bot merged commit 13b9af5 into tikv:release-8.5 Aug 8, 2025
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-18785-to-release-8.5 branch August 8, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breezewish breezewish breezewish approved these changes

@overvenus overvenus overvenus approved these changes

+1 more reviewer

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @Defined2014 @breezewish @overvenus @wjhuang2016