Skip to content

Titan: Add a regression test for Titan disabling (#18477)#18546

Merged
ti-chi-bot[bot] merged 5 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-18477-to-release-8.5
Jun 30, 2025
Merged

Titan: Add a regression test for Titan disabling (#18477)#18546
ti-chi-bot[bot] merged 5 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-18477-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jun 13, 2025

This is an automated cherry-pick of #18477

What is changed and how it works?

Issue Number: Close #18434

What's Changed:

The real bug has been fixed by distinguishing Titan blob index from RocksDB blob index during RocksDB upgrade effort.
This PR just adds a regression test to prove it is fixed.
We reproduced the error with the same test code in 7.5

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@ti-chi-bot ti-chi-bot added affects-8.5 This bug affects the 8.5.x(LTS) versions. affects-9.0 This bug affects the 9.0.x versions. dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jun 13, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 13, 2025
Merged
9 tasks
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 13, 2025
@v01dstar v01dstar force-pushed the cherry-pick-18477-to-release-8.5 branch from 9efb191 to ab6df58 Compare June 14, 2025 05:28
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 16, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LykxSassinator, v01dstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 16, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 16, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-13 06:17:17.473406148 +0000 UTC m=+595015.701721428: ☑️ agreed by v01dstar.
  • 2025-06-16 06:16:50.860814561 +0000 UTC m=+79663.583993543: ☑️ agreed by LykxSassinator.

@ti-chi-bot ti-chi-bot bot added the approved label Jun 16, 2025
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 30, 2025
v01dstar added 5 commits June 30, 2025 14:59
@v01dstar
Add a regression test for Titan disabling
a96ad07 
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
@v01dstar
Fix clippy
b498884 
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
@v01dstar
Fix lint
e99b43f 
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
@v01dstar
Revert raft engine update
3a79367 
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
@v01dstar
Use raft-engine tikv-8.5 branch
4e03ed9 
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
@v01dstar v01dstar force-pushed the cherry-pick-18477-to-release-8.5 branch from 0856449 to 4e03ed9 Compare June 30, 2025 22:00
@ti-chi-bot ti-chi-bot bot merged commit 8184d88 into tikv:release-8.5 Jun 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@v01dstar v01dstar v01dstar approved these changes

@LykxSassinator LykxSassinator LykxSassinator approved these changes

@overvenus overvenus Awaiting requested review from overvenus

Assignees

@v01dstar v01dstar

Labels

affects-8.5 This bug affects the 8.5.x(LTS) versions. affects-9.0 This bug affects the 9.0.x versions. approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @v01dstar @LykxSassinator