*: Update rust toolchain to nightly-2025-04-03#18416
*: Update rust toolchain to nightly-2025-04-03#18416ti-chi-bot[bot] merged 20 commits intotikv:masterfrom
Conversation
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
|
Have you compared the build time before and after upgrading Rust? |
[LGTM Timeline notifier]Timeline:
|
| #[allow(dead_code)] | ||
| fn or_io_error<D: Display>(self, msg: D) -> io::Result<Self::Ok>; |
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
|
/cc @cfzjywxk @zhangjinpeng87 PTAL |
|
@glorv: GitHub didn't allow me to request PR reviews from the following users: PTAL. Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/release |
Comparing the build to between this PR and master in the CI env: So it's a litter faster, but not much. |
|
@zhangjinpeng87 PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, Connor1996, hhwyt, LykxSassinator, overvenus, v01dstar, zhangjinpeng87 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
There is a building issue caused by it: #18465 |
What is changed and how it works?
Issue Number: Ref #17465
What's Changed:
NOTE: this PR does not update the edition version, we can do this is a separate PR.
Performance Benchmark:
I have benchmarked this PR vs commit
c93e28ewith benchbot sysbench workloads, the result is:(details: http://perf.pingcap.net/d/iarAjGo7z/benchbot-overview?orgId=1&var-email=All&var-testbed=benchbot-amd64-2xl-sysbench-tps-7759291-1-993&from=1745913985000)
Another benchmark that only ran "oltp_write_only" with the same configurations:
(details: http://perf.pingcap.net/d/iarAjGo7z/benchbot-overview?orgId=1&var-email=All&var-testbed=benchbot-amd64-2xl-sysbench-tps-7860707-1-783&from=1745977197000)
So the regression of "oltp_write_only" is likely due to environment issues.
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note