Skip to content

sst_importer: Get Memory limit at the sst service initialization (#18321)#18333

Merged
ti-chi-bot[bot] merged 4 commits intotikv:release-9.0-beta.1from
ti-chi-bot:cherry-pick-18321-to-release-9.0-beta.1
Mar 21, 2025
Merged

sst_importer: Get Memory limit at the sst service initialization (#18321)#18333
ti-chi-bot[bot] merged 4 commits intotikv:release-9.0-beta.1from
ti-chi-bot:cherry-pick-18321-to-release-9.0-beta.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Mar 21, 2025

This is an automated cherry-pick of #18321

What is changed and how it works?

Issue Number: Close #18317

  1. Get memory limit multiple times is unnecessary.
  2. The previous memory checks's granularity was too fine, performing a check on every chunk. Since Lightning writes in 16KB chunks, the frequent checks resulted in noticeable overhead.

What's Changed:

  1. This PR change the behavior to only get memory limit once at beginning.
  2. This PR adjusts the memory check to be performed per request instead of per chunk
sst_importer: Get Memory limit at the sst service initialization #18321

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

Signed-off-by: 3pointer <luancheng@pingcap.com>
Signed-off-by: 3pointer <luancheng@pingcap.com>
Signed-off-by: 3pointer <luancheng@pingcap.com>
Signed-off-by: 3pointer <luancheng@pingcap.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-9.0-beta.1 labels Mar 21, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 21, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 21, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 21, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-21 07:44:41.443828025 +0000 UTC m=+600775.128064116: ☑️ agreed by 3pointer.
  • 2025-03-21 07:47:31.40593395 +0000 UTC m=+600945.090170041: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Mar 21, 2025
@ti-chi-bot ti-chi-bot bot merged commit 570d009 into tikv:release-9.0-beta.1 Mar 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-9.0-beta.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants