log backup: fix several issues during compact log backup. (#18298)#18316
Merged
ti-chi-bot[bot] merged 6 commits intotikv:release-9.0-beta.1from Mar 21, 2025
Merged
Conversation
Signed-off-by: 3pointer <luancheng@pingcap.com>
Signed-off-by: 3pointer <luancheng@pingcap.com>
Signed-off-by: 3pointer <luancheng@pingcap.com>
Signed-off-by: 3pointer <luancheng@pingcap.com>
Signed-off-by: 3pointer <luancheng@pingcap.com>
9 tasks
Leavrth
approved these changes
Mar 21, 2025
YuJuncen
approved these changes
Mar 21, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leavrth, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Contributor
|
/retest |
Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
Contributor
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #18298
What is changed and how it works?
Issue Number: Close #18308
What's Changed:
1. GCS Atomic Write: Removed the content length=0 check to support atomic writes, aligning with S3 behavior.
2. Assertion Fix: Fixed assertion failures caused by unexpected rollback transactions. see details(#18300)
3. Duplicate File Fix: Resolved issues with duplicate output files causing compacted restore failures.
4. Enhanced logging to reduce noise.
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note