Skip to content

raftstore: skip sync WAL for transfer leader admin commands#18277

Merged
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
overvenus:p99/transfer-leader-no-sync
Mar 7, 2025
Merged

raftstore: skip sync WAL for transfer leader admin commands#18277
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
overvenus:p99/transfer-leader-no-sync

Conversation

@overvenus
Copy link
Member

What is changed and how it works?

Issue Number: close #18275

What's Changed:

Excluding TransferLeader from WAL synchronization, TiKV can reduce unnecessary I/O operations, thereby mitigating latency spikes during leader transfers.


Check List

Tests

  • Unit test

Release note

None

Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 5, 2025
Copy link
Contributor

@LykxSassinator LykxSassinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 5, 2025
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, LykxSassinator

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [LykxSassinator,glorv]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 7, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-05 07:51:14.541559996 +0000 UTC m=+427987.670479732: ☑️ agreed by LykxSassinator.
  • 2025-03-07 06:50:30.431702759 +0000 UTC m=+597143.560622501: ☑️ agreed by glorv.

@ti-chi-bot ti-chi-bot bot merged commit 9948b0c into tikv:master Mar 7, 2025
8 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply threads can skip unnecessary WAL sync for TransferLeader admin commands

3 participants