Skip to content

cdc: fix the panic introduced by #17656 (#18143)#18170

Merged
hicqu merged 1 commit intotikv:release-7.5-20250124-v7.5.5from
hicqu:release-7.5-20250124-v7.5.5
Jan 24, 2025
Merged

cdc: fix the panic introduced by #17656 (#18143)#18170
hicqu merged 1 commit intotikv:release-7.5-20250124-v7.5.5from
hicqu:release-7.5-20250124-v7.5.5

Conversation

@hicqu
Copy link
Contributor

@hicqu hicqu commented Jan 24, 2025

What is changed and how it works?

Issue Number: Close #18142

It's a cherry-pick of #18143 .

What's Changed:

#17656 skips to put unobserved events into the Resolver. It's incorrect.
This PR fixes this.

cdc: fix the panic introduced by #17656

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@hicqu @ti-chi-bot
cdc: fix the panic introduced by tikv#17656 (tikv#18143)
6207b5e 
close tikv#18142

cdc: fix the panic introduced by tikv#17656

Signed-off-by: qupeng <qupeng@pingcap.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Jan 24, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hicqu, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 24, 2025
@hicqu
Copy link
Contributor Author

hicqu commented Jan 24, 2025

/retest

@hicqu hicqu merged commit 500c21a into tikv:release-7.5-20250124-v7.5.5 Jan 24, 2025
3 of 4 checks passed
@hicqu hicqu deleted the release-7.5-20250124-v7.5.5 branch January 24, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hicqu