Skip to content

cdc: fix the panic introduced by #17656 (#18143)#18165

Merged
ti-chi-bot[bot] merged 4 commits intotikv:release-7.1from
ti-chi-bot:cherry-pick-18143-to-release-7.1
Jan 23, 2025
Merged

cdc: fix the panic introduced by #17656 (#18143)#18165
ti-chi-bot[bot] merged 4 commits intotikv:release-7.1from
ti-chi-bot:cherry-pick-18143-to-release-7.1

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #18143

What is changed and how it works?

Issue Number: Close #18142

What's Changed:

#17656 skips to put unobserved events into the Resolver. It's incorrect.
This PR fixes this.

cdc: fix the panic introduced by #17656

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

hicqu added 3 commits January 23, 2025 06:23
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Jan 23, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 23, 2025
Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, hicqu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 23, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 23, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-23 06:25:33.723053238 +0000 UTC m=+334861.053972637: ☑️ agreed by hicqu.
  • 2025-01-23 06:28:58.304310768 +0000 UTC m=+335065.635230167: ☑️ agreed by 3AceShowHand.

@ti-chi-bot ti-chi-bot bot merged commit d80c6ec into tikv:release-7.1 Jan 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants