Skip to content

expr: support scalar function str_to_date in tikv#18147

Merged
ti-chi-bot[bot] merged 6 commits intotikv:masterfrom
wshwsh12:strtodate
Feb 10, 2025
Merged

expr: support scalar function str_to_date in tikv#18147
ti-chi-bot[bot] merged 6 commits intotikv:masterfrom
wshwsh12:strtodate

Conversation

@wshwsh12
Copy link
Contributor

What is changed and how it works?

Issue Number: Close #18146

What's Changed:

Support scalar function str_to_date in tikv

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Support scalar function str_to_date in tikv

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the dco. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 21, 2025
Signed-off-by: wshwsh12 <793703860@qq.com>
Signed-off-by: wshwsh12 <793703860@qq.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 5, 2025
@wshwsh12
Copy link
Contributor Author

wshwsh12 commented Feb 6, 2025

/cc @breezewish

@ti-chi-bot ti-chi-bot bot requested a review from breezewish February 6, 2025 07:02
@LykxSassinator
Copy link
Contributor

Please add some necessary comments to clarify why we implement this manually (following the standard specified in MySQL) instead of using chrono::DateTime.

Copy link
Contributor

@LykxSassinator LykxSassinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

Signed-off-by: wshwsh12 <793703860@qq.com>
wshwsh12 and others added 2 commits February 7, 2025 17:12
Co-authored-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: Shenghui Wu <wshwsh12@outlook.com>
@wshwsh12
Copy link
Contributor Author

wshwsh12 commented Feb 7, 2025

/retest

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, LykxSassinator

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [LykxSassinator,gengliqi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 10, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-05 12:36:30.486266609 +0000 UTC m=+275262.018678602: ☑️ agreed by gengliqi.
  • 2025-02-10 07:28:01.620994589 +0000 UTC m=+255124.017216648: ☑️ agreed by LykxSassinator.

@ti-chi-bot ti-chi-bot bot merged commit 9001853 into tikv:master Feb 10, 2025
8 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support scalar function str_to_date in tikv

3 participants