concurrency_manager: check update_max_ts against a limit (#17917)#18049
Merged
ti-chi-bot[bot] merged 6 commits intotikv:release-7.5from Jan 8, 2025
Merged
Conversation
9 tasks
Signed-off-by: ekexium <eke@fastmail.com>
b6c199a to
2d40b5f
Compare
Contributor
|
/retest |
…f invalid max-ts update (tikv#18057) close tikv#18055 concurrency_manager: double check via PD TSO before reporting error of invalid max-ts update Signed-off-by: ekexium <eke@fastmail.com>
ref tikv#18055 When validating max-ts updates, do not report error or panic unless confirmed by PD TSO. This reduces both false positive and false negative cases. Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Contributor
|
/retest |
1 similar comment
Contributor
|
/retest |
Signed-off-by: ekexium <eke@fastmail.com>
you06
approved these changes
Jan 8, 2025
MyonKeminta
approved these changes
Jan 8, 2025
Contributor
[LGTM Timeline notifier]Timeline:
|
Contributor
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Contributor
|
/hold |
Contributor
|
/unhold |
f27ddc7 to
7a7c3a8
Compare
Contributor
|
/retest |
Signed-off-by: ekexium <eke@fastmail.com>
7a7c3a8 to
b2c29c5
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MyonKeminta, you06 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #17917
What is changed and how it works?
Issue Number: close #17916
What's Changed:
Metric:
Benchmark of
update_max_ts:master
This PR
Read operations typically need hundreds of microseconds, so I suppose this regression has little impact.
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note