raftstore: Fix flaky test_split_region_with_no_valid_split_keys#17953
Merged
ti-chi-bot[bot] merged 3 commits intotikv:masterfrom Dec 10, 2024
Merged
raftstore: Fix flaky test_split_region_with_no_valid_split_keys#17953ti-chi-bot[bot] merged 3 commits intotikv:masterfrom
ti-chi-bot[bot] merged 3 commits intotikv:masterfrom
Conversation
The test expects a split to occur but sometimes failed because the split check was triggered too early (before the DB had enough keys) and found no split key. Once the first split check finds nothing, subsequent checks are delayed until size_diff_hint (an approximate measure of region size change) reaches the region_split_check_diff threshold. By lowering this threshold (default: 10,000, defined in components/test_raftstore/src/common-test.toml), the second split check is triggered in time to meet the test's expectations. Before the fix, the failure can be consistently reproduced within 100 runs. After the fix, there is no failure after 500 runs. Signed-off-by: Bisheng Huang <hbisheng@gmail.com>
Contributor
|
/check-issue-triage-complete |
glorv
approved these changes
Dec 9, 2024
LykxSassinator
approved these changes
Dec 10, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: glorv, LykxSassinator The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
Contributor
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Issue Number: Close #17557
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note