expr: fix panic when using radians and degree (#17853)#17860
Merged
ti-chi-bot[bot] merged 2 commits intotikv:release-6.5from Nov 19, 2024
Merged
expr: fix panic when using radians and degree (#17853)#17860ti-chi-bot[bot] merged 2 commits intotikv:release-6.5from
ti-chi-bot[bot] merged 2 commits intotikv:release-6.5from
Conversation
Signed-off-by: gengliqi <gengliqiii@gmail.com>
9 tasks
gengliqi
approved these changes
Nov 19, 2024
breezewish
approved these changes
Nov 19, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breezewish, gengliqi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
Member
|
/retest |
1 similar comment
Member
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #17853
What is changed and how it works?
Issue Number: Close #17852
What's Changed:
radianschanges fromarg * PI / 180toarg * (PI / 180)to avoid infinite float issues. FYI: https://github.com/mysql/mysql-server/blob/ee079e5ca930ce5ed0643326abadeed8cd41fffc/sql/item_func.h#L1556 MySQL also calculatePI / 180firstly.degreescan be infinite so adding a check for it.Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note