Skip to content

raftstore: skip handle remaining messages if peer is destroyed (#17841)#17849

Merged
ti-chi-bot[bot] merged 3 commits intotikv:release-6.5from
ti-chi-bot:cherry-pick-17841-to-release-6.5
Nov 20, 2024
Merged

raftstore: skip handle remaining messages if peer is destroyed (#17841)#17849
ti-chi-bot[bot] merged 3 commits intotikv:release-6.5from
ti-chi-bot:cherry-pick-17841-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #17841

What is changed and how it works?

Issue Number: Close #17840

What's Changed:

Skip handling remain raft messages after peer fsm is stopped. This can avoid potential panic if the raft message need to read raft log from raft engine.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

close tikv#17840

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Nov 19, 2024
Signed-off-by: glorv <glorvs@163.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 19, 2024
Signed-off-by: glorv <glorvs@163.com>
@glorv glorv force-pushed the cherry-pick-17841-to-release-6.5 branch from 8340aa0 to 20db566 Compare November 20, 2024 03:01
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 20, 2024

@hbisheng: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@glorv glorv requested a review from Connor1996 November 20, 2024 06:49
@glorv
Copy link
Contributor

glorv commented Nov 20, 2024

@Connor1996 PTAL

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Connor1996, glorv, hbisheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 20, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-19 11:13:47.654455679 +0000 UTC m=+959589.845324676: ☑️ agreed by glorv.
  • 2024-11-20 08:23:01.562402916 +0000 UTC m=+19969.182057432: ☑️ agreed by Connor1996.

@ti-chi-bot ti-chi-bot bot merged commit 2b9a3c4 into tikv:release-6.5 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants