Skip to content

raftstore: skip handle remaining messages if peer is destroyed (#17841)#17848

Merged
ti-chi-bot[bot] merged 4 commits intotikv:release-7.5from
ti-chi-bot:cherry-pick-17841-to-release-7.5
Nov 20, 2024
Merged

raftstore: skip handle remaining messages if peer is destroyed (#17841)#17848
ti-chi-bot[bot] merged 4 commits intotikv:release-7.5from
ti-chi-bot:cherry-pick-17841-to-release-7.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 19, 2024

This is an automated cherry-pick of #17841

What is changed and how it works?

Issue Number: Close #17840

What's Changed:

Skip handling remain raft messages after peer fsm is stopped. This can avoid potential panic if the raft message need to read raft log from raft engine.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

glorv added 2 commits November 19, 2024 10:59
@glorv @ti-chi-bot
skip handle remaining messages if peer is destroyed
2e451ff 
Signed-off-by: glorv <glorvs@163.com>
@glorv @ti-chi-bot
use assert
0f95e1c 
Signed-off-by: glorv <glorvs@163.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 19, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 19, 2024
Merged
9 tasks
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 19, 2024
@glorv
fix test
4cb432d 
Signed-off-by: glorv <glorvs@163.com>
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 20, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, hbisheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 20, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-19 11:05:22.40223694 +0000 UTC m=+959084.593105930: ☑️ agreed by glorv.
  • 2024-11-20 03:03:28.830670985 +0000 UTC m=+796.450325501: ☑️ agreed by hbisheng.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 20, 2024

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@glorv
Copy link
Contributor

glorv commented Nov 20, 2024

/retest

2 similar comments
@glorv
Copy link
Contributor

glorv commented Nov 20, 2024

/retest

@glorv
Copy link
Contributor

glorv commented Nov 20, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 8e8dae3 into tikv:release-7.5 Nov 20, 2024
@glorv glorv deleted the cherry-pick-17841-to-release-7.5 branch November 20, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glorv glorv glorv approved these changes

+1 more reviewer

@hbisheng hbisheng hbisheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@glorv glorv

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @glorv @hbisheng