Skip to content

cdc: do not send too much tasks if cannot be handled in time (#17724)#17778

Merged
ti-chi-bot[bot] merged 27 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-17724-to-release-8.5
Nov 13, 2024
Merged

cdc: do not send too much tasks if cannot be handled in time (#17724)#17778
ti-chi-bot[bot] merged 27 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-17724-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #17724

What is changed and how it works?

Issue Number: Close #17696

What's Changed:

* take cdc tasks into memory quota to prevent the TiKV OOM caused by too many pending tasks

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

fix the TiKV may oom if too much internal pending tasks due to read old value too slow

3AceShowHand and others added 26 commits November 6, 2024 06:54
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 6, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 8, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, LykxSassinator

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 13, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-08 09:00:18.51697935 +0000 UTC m=+1180.707848349: ☑️ agreed by 3AceShowHand.
  • 2024-11-13 07:33:51.932724869 +0000 UTC m=+427994.123593861: ☑️ agreed by LykxSassinator.

@LykxSassinator
Copy link
Contributor

/test pull-unit-test

@ti-chi-bot ti-chi-bot bot merged commit d1c4c6d into tikv:release-8.5 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants