Add metrics for raft message send wait & receive delay duration#17735
Add metrics for raft message send wait & receive delay duration#17735ti-chi-bot[bot] merged 17 commits intotikv:masterfrom
Conversation
|
Hi @hhwyt. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fd2f408 to
ae7878c
Compare
756da92 to
0358aa4
Compare
|
/cc @glorv @Connor1996 @hbisheng @LykxSassinator PTAL, thanks~ Please also review the related PR: pingcap/kvproto#1276. |
components/tikv_util/src/time.rs
Outdated
src/server/raft_client.rs
Outdated
There was a problem hiding this comment.
The performance result didn't show any difference. Do we really need local metrics?
There was a problem hiding this comment.
Previously, we encountered global metrics to be a performance impact. As it wouldn't take much effort to make it local, better do it. Check make_auto_flush_static_metric!
There was a problem hiding this comment.
@Connor1996 This job is done. PTAL again, thx~
|
Please run a benchmark for it to see if there is any regression |
e853922 to
3a68bbe
Compare
The test result has already been provided in the first comment above. @Connor1996 |
|
@Connor1996 PTAL, thx~ |
|
Pls check and fix the |
These errors is due to the lack of the |
|
@LykxSassinator I added a temporary commit to switch the kvproto repo to my repo. This commit will not be merged into master. |
|
/retest |
|
@hhwyt: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6532cec to
b8768ca
Compare
Signed-off-by: hhwyt <hhwyt1@gmail.com>
Signed-off-by: hhwyt <hhwyt1@gmail.com>
Signed-off-by: hhwyt <hhwyt1@gmail.com>
This commit will not be merged into master. Signed-off-by: hhwyt <hhwyt1@gmail.com>
Signed-off-by: hhwyt <hhwyt1@gmail.com>
Co-authored-by: Connor <zbk602423539@gmail.com> Signed-off-by: hhwyt <hhwyt1@gmail.com>
Co-authored-by: Connor <zbk602423539@gmail.com> Signed-off-by: hhwyt <hhwyt1@gmail.com>
Signed-off-by: hhwyt <hhwyt1@gmail.com>
Signed-off-by: hhwyt <hhwyt1@gmail.com>
Signed-off-by: hhwyt <hhwyt1@gmail.com>
Signed-off-by: hhwyt <hhwyt1@gmail.com>
Signed-off-by: hhwyt <hhwyt1@gmail.com>
Signed-off-by: hhwyt <hhwyt1@gmail.com>
This reverts commit b8768ca9c74f8ae909d83b9fe1c4cbdd68b71f6f. Signed-off-by: hhwyt <hhwyt1@gmail.com>
Signed-off-by: hhwyt <hhwyt1@gmail.com>
Signed-off-by: hhwyt <hhwyt1@gmail.com>
0ab96d1 to
6624c90
Compare
Signed-off-by: hhwyt <hhwyt1@gmail.com>
|
/pull-unit-test |
|
/test pull-unit-test |
What is changed and how it works?
Issue Number: Close #17683
What's Changed:
Grafana new panel:

Benchbot result:


The benchmark results for sysbench oltp_insert and oltp_write_only show no impact on performance.
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note