Skip to content

tikv_alloc: Add per thread memory usage (#16255)#17005

Merged
ti-chi-bot[bot] merged 3 commits intotikv:release-8.1from
ti-chi-bot:cherry-pick-16255-to-release-8.1
May 13, 2024
Merged

tikv_alloc: Add per thread memory usage (#16255)#17005
ti-chi-bot[bot] merged 3 commits intotikv:release-8.1from
ti-chi-bot:cherry-pick-16255-to-release-8.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented May 13, 2024 •
edited by Connor1996
Loading

This is an automated cherry-pick of #16255

What is changed and how it works?

Issue Number: Ref #15927 #17006

What's Changed:

Add per thread memory usage

Jemalloc has mapped memory stats per arena. We can bind each thread with a dedicated arena, then we have per thread memory usage.

The total memory ~== block cache size + total of per thread footprint
截屏2024-04-07 16 28 25

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Add per thread memory usage

@Connor1996 @ti-chi-bot
This is an automated cherry-pick of tikv#16255
d465821 
ref tikv#15927

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 13, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request May 13, 2024
Merged
9 tasks
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 13, 2024 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels May 13, 2024
@Connor1996
regen grafana board
a4c9797 
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Connor1996
Connor1996 approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 13, 2024
@Connor1996 Connor1996 mentioned this pull request May 13, 2024
Closed
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 13, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 13, 2024
@glorv
Copy link
Contributor

glorv commented May 13, 2024

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 13, 2024

@glorv: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 13, 2024

This pull request has been accepted and is ready to merge.

DetailsCommit hash: a4c9797

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 13, 2024

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 278551a into tikv:release-8.1 May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overvenus overvenus overvenus approved these changes

@glorv glorv glorv approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

Assignees

@Connor1996 Connor1996

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @glorv @overvenus @Connor1996