Skip to content

copr: fix cast_bytes_like_as_duration encoding failed (#15819)#15828

Closed
ti-chi-bot wants to merge 1 commit intotikv:release-7.1from
ti-chi-bot:cherry-pick-15819-to-release-7.1
Closed

copr: fix cast_bytes_like_as_duration encoding failed (#15819)#15828
ti-chi-bot wants to merge 1 commit intotikv:release-7.1from
ti-chi-bot:cherry-pick-15819-to-release-7.1

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #15819

What is changed and how it works?

Issue Number: Close #15820

What's Changed:

fix cast_bytes_like_as_duration encoding failed

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
tidb> CREATE TABLE t0(c0 BLOB(10));
Query OK, 0 rows affected (0.954 sec)

tidb> INSERT INTO t0(c0) VALUES (unhex('926B'));
Query OK, 1 row affected (0.101 sec)

tidb> SELECT t0.c0 FROM t0 WHERE CAST(REVERSE(t0.c0) AS TIME);
Empty set, 1 warning (0.012 sec)

tidb> show warnings;
+---------+------+-----------------------------------------------------------+
| Level   | Code | Message                                                   |
+---------+------+-----------------------------------------------------------+
| Warning | 1292 | evaluation failed: Truncated incorrect TIME value: 'k�'   |
+---------+------+-----------------------------------------------------------+
1 row in set (0.000 sec)

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

Fix casting bytes to time encoding failed

Signed-off-by: wshwsh12 <793703860@qq.com>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Oct 23, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 23, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 23, 2023

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants