Skip to content

resource_manager: add watch for resource group #14022

Merged
ti-chi-bot merged 20 commits intotikv:masterfrom
HuSharp:resource_group_watch
Jan 20, 2023
Merged

resource_manager: add watch for resource group #14022
ti-chi-bot merged 20 commits intotikv:masterfrom
HuSharp:resource_group_watch

Conversation

@HuSharp
Copy link
Member

@HuSharp HuSharp commented Jan 6, 2023 •
edited
Loading

Signed-off-by: husharp <ihusharp@gmai;.com>

What is changed and how it works?

Issue Number: Close #13983 Ref #13730

What's Changed:

- add etcd mock for pd
- add service for resource group

Check List

Tests

  • Unit test
  • Integration test

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 6, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. contribution This PR is from a community contributor. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 6, 2023
@HuSharp HuSharp force-pushed the resource_group_watch branch 4 times, most recently from 742724e to 795caa0 Compare January 9, 2023 09:00
@HuSharp HuSharp mentioned this pull request Jan 10, 2023
Merged
@HuSharp HuSharp force-pushed the resource_group_watch branch 2 times, most recently from 32a6937 to 9389db3 Compare January 11, 2023 06:49
JmPotato
JmPotato reviewed Jan 11, 2023
View reviewed changes
HuSharp
HuSharp commented Jan 11, 2023
View reviewed changes
@HuSharp HuSharp mentioned this pull request Jan 12, 2023
Closed
@HuSharp
support etcd and resource group
815f359 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp force-pushed the resource_group_watch branch from 834713e to 815f359 Compare January 13, 2023 01:57
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2023
@HuSharp HuSharp marked this pull request as ready for review January 13, 2023 01:58
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2023
@HuSharp
Copy link
Member Author

HuSharp commented Jan 13, 2023 •
edited
Loading

/cc @glorv @nolouch @JmPotato Pls take a look! thx!!!

@HuSharp
make format happy
0b7e7b9 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp force-pushed the resource_group_watch branch from 1debda1 to 0b7e7b9 Compare January 13, 2023 02:28
glorv
glorv reviewed Jan 13, 2023
View reviewed changes
@HuSharp
address comment
12729b0 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
add test
4aa6a29 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp force-pushed the resource_group_watch branch from f457c8e to 4aa6a29 Compare January 13, 2023 05:11
glorv
glorv reviewed Jan 13, 2023
View reviewed changes
@HuSharp
add retry test
6e81034 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
glorv
glorv reviewed Jan 18, 2023
View reviewed changes
@HuSharp
add list loop
6b39460 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
make clippy happy
f3cc1b5 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
glorv
glorv reviewed Jan 18, 2023
View reviewed changes
@HuSharp
add list loop
20cab99 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
refine code
0bd4d72 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
glorv
glorv reviewed Jan 18, 2023
View reviewed changes
Copy link
Contributor

@glorv glorv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the logic is correct now.

@glorv
Copy link
Contributor

glorv commented Jan 18, 2023

@Connor1996 PTAL

@HuSharp
address comment
f2c92cc 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
Copy link
Member Author

HuSharp commented Jan 18, 2023

I think the logic is correct now.

Thx for ur comments!

glorv
glorv reviewed Jan 18, 2023
View reviewed changes
@HuSharp
address comment
362052c 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
make clippy happy
b5c5ab1 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2023
@HuSharp
Copy link
Member Author

HuSharp commented Jan 19, 2023 •
edited
Loading

@nolouch @Connor1996 @BornChanger @JmPotato friendly ping :)

nolouch
nolouch approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 20, 2023
Connor1996
Connor1996 approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 20, 2023
@Connor1996
Copy link
Member

Connor1996 commented Jan 20, 2023

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 20, 2023

@Connor1996: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 20, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b5c5ab1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 20, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 20, 2023

@HuSharp: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@HuSharp
Copy link
Member Author

HuSharp commented Jan 20, 2023

/test

@ti-chi-bot ti-chi-bot merged commit f178f78 into tikv:master Jan 20, 2023
@ti-chi-bot ti-chi-bot added this to the Pool milestone Jan 20, 2023
@HuSharp HuSharp deleted the resource_group_watch branch January 20, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glorv glorv glorv left review comments

@Connor1996 Connor1996 Connor1996 approved these changes

+3 more reviewers

@JmPotato JmPotato JmPotato left review comments

@nolouch nolouch nolouch approved these changes

@BornChanger BornChanger BornChanger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contribution This PR is from a community contributor. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

Provide a way let the client can watch the configuration changes

7 participants

@HuSharp @ti-chi-bot @BornChanger @nolouch @glorv @Connor1996 @JmPotato