Skip to content

log-backup: fix slow flush in GCP#13674

Merged
ti-chi-bot merged 14 commits intotikv:masterfrom
YuJuncen:fix-gcs-slow
Oct 28, 2022
Merged

log-backup: fix slow flush in GCP#13674
ti-chi-bot merged 14 commits intotikv:masterfrom
YuJuncen:fix-gcs-slow

Conversation

@YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Oct 26, 2022 •
edited
Loading

What is changed and how it works?

Issue Number: Close #13688 ; close pingcap/tidb#38642

What's Changed:
This PR used an alternative of the read_to_end to get rid of the performance issue of the origin version of read_to_end.

This PR also have enhanced observability for GCS external storage.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    I have tested read via read_to_end and this implementation in a short code snippet, it is about 200x faster (120s vs 600ms) than the origin read_to_end when reading a 128MB file.

Release note 

Fixed a bug that may cause high lag of checkpoints in the GCS storage.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 26, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 26, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 26, 2022
@overvenus
Copy link
Member

overvenus commented Oct 26, 2022

Is it possible to add a benchmark?

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-triage-completed labels Oct 26, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 26, 2022
YuJuncen and others added 7 commits October 26, 2022 18:23
@YuJuncen
added gcp put duration
8849ef9 
Signed-off-by: hillium <yujuncen@pingcap.com>
@YuJuncen
use manual read_to_end
7a0832e 
Signed-off-by: hillium <yujuncen@pingcap.com>
@YuJuncen
fix build
139a04d 
Signed-off-by: hillium <yujuncen@pingcap.com>
@YuJuncen
added bench
5ca5c9c 
Signed-off-by: hillium <yujuncen@pingcap.com>
@YuJuncen
fix bench
5c97246 
Signed-off-by: hillium <yujuncen@pingcap.com>
@YuJuncen
make clippy happy
d0ab667 
Signed-off-by: hillium <yujuncen@pingcap.com>
@YuJuncen
Update Cargo.toml
5af5057 
Signed-off-by: hillium <yujuncen@pingcap.com>
overvenus
overvenus reviewed Oct 27, 2022
View reviewed changes
@YuJuncen
reuse buffer in benchmark
9bc7603 
Signed-off-by: hillium <yujuncen@pingcap.com>
overvenus
overvenus reviewed Oct 27, 2022
View reviewed changes
@YuJuncen
update bench result
5283ded 
Signed-off-by: hillium <yujuncen@pingcap.com>
@overvenus
Copy link
Member

overvenus commented Oct 28, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 28, 2022

@overvenus: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 28, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 5283ded

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 28, 2022
@YuJuncen
Copy link
Contributor Author

YuJuncen commented Oct 28, 2022

(Manually removed do-not-merge/needs-linked-issue because it has already linked to a issue in the pingcap/tidb repo)

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 28, 2022

@YuJuncen: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot removed status/can-merge Indicates a PR has been approved by a committer. do-not-merge/needs-linked-issue labels Oct 28, 2022
@overvenus
Copy link
Member

overvenus commented Oct 28, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 28, 2022

@overvenus: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 28, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 44dfa3c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 28, 2022
@ti-chi-bot ti-chi-bot merged commit fe61a03 into tikv:master Oct 28, 2022
@ti-chi-bot ti-chi-bot added this to the Pool milestone Oct 28, 2022
@YuJuncen YuJuncen mentioned this pull request Apr 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overvenus overvenus overvenus approved these changes

@kennytm kennytm Awaiting requested review from kennytm

+1 more reviewer

@3pointer 3pointer 3pointer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

pitr backup lag continuously increase in dbaas gcp environment pitr backup lag continuously increase in dbaas gcp environment

4 participants

@YuJuncen @ti-chi-bot @overvenus @3pointer