Skip to content

config: override rocksdb config when flow control enabled (#11840)#11863

Merged
ti-chi-bot merged 4 commits intotikv:release-5.2from
ti-srebot:release-5.2-2c9f5fda36ca
Apr 12, 2022
Merged

config: override rocksdb config when flow control enabled (#11840)#11863
ti-chi-bot merged 4 commits intotikv:release-5.2from
ti-srebot:release-5.2-2c9f5fda36ca

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jan 13, 2022 •
edited
Loading

cherry-pick #11840 to release-5.2
You can switch your code base to this Pull Request by using git-extras:

# In tikv repo:
git pr https://github.com/tikv/tikv/pull/11863

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tikv.git pr/11863:release-5.2-2c9f5fda36ca

Signed-off-by: Connor1996 zbk602423539@gmail.com

What is changed and how it works?

Close #11424

What's Changed:

Override the related config in RocksDB, so ingest_maybe_stall can be calculated correctly which is based on level0_slowdown_trigger when flow control is enabled.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Release note 

Fix possible QPS drop when `level0_slowdown_trigger` is set explicitly with flow control enabled.

@Connor1996 @ti-srebot
cherry pick tikv#11840 to release-5.2
7ae3db6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 13, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • tabokie

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 13, 2022
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jan 13, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 13, 2022
@ti-srebot ti-srebot mentioned this pull request Jan 13, 2022
Merged
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick Type: PR - Cherry pick labels Jan 13, 2022
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jan 13, 2022

@Connor1996 you're already a collaborator in bot's repo.

Connor1996
Connor1996 approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 26, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 26, 2022
@Connor1996 Connor1996 added this to the v5.2.4 milestone Jan 26, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 12, 2022
@MyonKeminta
Copy link
Contributor

MyonKeminta commented Apr 12, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 12, 2022

@MyonKeminta: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 12, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 7ae3db6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 12, 2022
@MyonKeminta
Copy link
Contributor

MyonKeminta commented Apr 12, 2022

/test

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 12, 2022

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit a2938f7 into tikv:release-5.2 Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Connor1996 Connor1996 Connor1996 approved these changes

@tabokie tabokie tabokie approved these changes

@hunterlxt hunterlxt Awaiting requested review from hunterlxt

Assignees

@Connor1996 Connor1996

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick Type: PR - Cherry pick

Projects

None yet

Milestone

v5.2.4

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-srebot @ti-chi-bot @MyonKeminta @Connor1996 @tabokie @VelocityLight