Skip to content

resolved_ts: return early after regions already had quorum (#11352)#11540

Merged
ti-chi-bot merged 2 commits intotikv:release-5.1from
ti-srebot:release-5.1-1e9f0b3a443c
Feb 8, 2022
Merged

resolved_ts: return early after regions already had quorum (#11352)#11540
ti-chi-bot merged 2 commits intotikv:release-5.1from
ti-srebot:release-5.1-1e9f0b3a443c

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Dec 2, 2021 •
edited
Loading

cherry-pick #11352 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tikv repo:
git pr https://github.com/tikv/tikv/pull/11540

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tikv.git pr/11540:release-5.1-1e9f0b3a443c

Signed-off-by: 5kbpers tangminghua@pingcap.com

What problem does this PR solve?

Issue Number: close #11351

Problem Summary:

What is changed and how it works?

What's Changed:

  • export region_resolved_ts_store from resolved_ts and import it in cdc
  • use select_all instead of join_all for returning early

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note 

Fix resolved ts lag increased after stoping a tikv

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 2, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 5kbpers
  • hicqu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Dec 2, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 2, 2021
@ti-srebot ti-srebot mentioned this pull request Dec 2, 2021
Merged
@ti-srebot ti-srebot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick Type: PR - Cherry pick labels Dec 2, 2021
@ti-srebot ti-srebot added this to the v5.1.3 milestone Dec 2, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Dec 2, 2021

@5kbpers you're already a collaborator in bot's repo.

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 24, 2022
@sticnarf
Copy link
Contributor

sticnarf commented Jan 26, 2022

@hicqu @overvenus PTAL

@ti-srebot @sticnarf
resolved_ts: return early after regions already had quorum (tikv#11352)…
3c96747 
… (tikv#11538)

* ref tikv#11351

Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
@sticnarf sticnarf force-pushed the release-5.1-1e9f0b3a443c branch from 74aaf8e to 3c96747 Compare February 8, 2022 05:56
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 8, 2022
@overvenus overvenus added the component/CDC Component: Change Data Capture label Feb 8, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 8, 2022
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 8, 2022
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 8, 2022
@overvenus
Copy link
Member

overvenus commented Feb 8, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 8, 2022

@overvenus: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 8, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: ec9f1e9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2022
@ti-chi-bot ti-chi-bot merged commit 736ca92 into tikv:release-5.1 Feb 8, 2022
@hicqu hicqu deleted the release-5.1-1e9f0b3a443c branch February 8, 2022 09:48
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.1.3, v5.1.4 Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overvenus overvenus overvenus approved these changes

@hicqu hicqu hicqu approved these changes

@5kbpers 5kbpers 5kbpers approved these changes

@liuzix liuzix Awaiting requested review from liuzix

@NingLin-P NingLin-P Awaiting requested review from NingLin-P

Assignees

@5kbpers 5kbpers

Labels

cherry-pick-approved Cherry pick PR approved by release team. component/CDC Component: Change Data Capture release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick Type: PR - Cherry pick

Projects

None yet

Milestone

v5.1.4

Development

Successfully merging this pull request may close these issues.

7 participants

@ti-srebot @ti-chi-bot @sticnarf @overvenus @hicqu @5kbpers @zhouqiang-cl