handle proposals correctly if majority peers are disk full#10671
handle proposals correctly if majority peers are disk full#10671ti-chi-bot merged 19 commits intotikv:masterfrom
Conversation
Signed-off-by: qupeng <qupeng@pingcap.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
One Advice: If we can change the intercept condition of processing the received raft message from "if not disk normal" to "if disk is already full", then ti will work fine, and no need to get disk usage info from followers. One advantage is Logically decoupling. |
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Of course it's a potential solution. However maintaining a Vec<(index, DiskFullOpt)> correctly in raftstore is not easy. You can take try if you have time. |
Signed-off-by: qupeng <qupeng@pingcap.com>
|
/merge |
|
@hicqu: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: f0cd626 |
|
@hicqu: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: qupeng qupeng@pingcap.com
What problem does this PR solve?
This PR handles proposals correctly for majority peers are disk full. It contains:
Raft::adjust_max_inflight_msgs.DiskFullOptflag, leader can broadcast it in order to commit it.Related changes
Check List
Tests
Release note