Skip to content

[Cherry-pick] CP #370 & #372 to tikv-7.5 #376

Merged
ti-chi-bot[bot] merged 14 commits intotikv:tikv-7.5from
LykxSassinator:cp-370-to-tikv7.5
Dec 4, 2024
Merged

[Cherry-pick] CP #370 & #372 to tikv-7.5 #376
ti-chi-bot[bot] merged 14 commits intotikv:tikv-7.5from
LykxSassinator:cp-370-to-tikv7.5

Conversation

@LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Dec 3, 2024 •
edited
Loading

This is a manual cherry-pick pr to cp #370 & #372 to tikv-7.5

Meanwhile, to make this CI work as expected, this pr has introduced a fixed Cargo.lock to ensure that cargo dependencies are fixed and stable, to pass through the CI.

@LykxSassinator
[Cherry-pick] CP tikv#370 & tikv#372 to tikv-7.5
0077579 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Fix lint errs.
66db515 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Fix lint errs.
0a33b85 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 3, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 3, 2024

@hbisheng: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@LykxSassinator
Lock grcov to a historical version.
0d3ca70 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Fix version.
f6ee8f9 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Fix build env.
81ec8cd 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Fix version on grcov to 0.8.9
94a4107 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Remove cache.
00fd45d 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Use 0.8.10
7beeef5 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Remove cache dependencies.
c1c9e52 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Fix kvproto dependencies build errs.
ecb7704 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Fix Cargo.lock to build with older version.
42addfd 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 4, 2024
@LykxSassinator
Revise workflows.
8478e8f 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Fix build errs.
c7a6fc3 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 4, 2024

@overvenus: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@LykxSassinator
Copy link
Contributor Author

LykxSassinator commented Dec 4, 2024

/approve

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Dec 4, 2024

/approve
/approve cancel

just for refresh the approve states

@ti-chi-bot ti-chi-bot bot added the approved label Dec 4, 2024
@LykxSassinator
Copy link
Contributor Author

LykxSassinator commented Dec 4, 2024

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbisheng, LykxSassinator, overvenus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [LykxSassinator,overvenus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot added the lgtm label Dec 4, 2024
@ti-chi-bot ti-chi-bot bot merged commit 8cb23f1 into tikv:tikv-7.5 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overvenus overvenus overvenus approved these changes

+1 more reviewer

@hbisheng hbisheng hbisheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LykxSassinator @wuhuizuo @overvenus @hbisheng @ti-chi-bot