Skip to content

[Cherry-pick] Fix panics on reading entries by stale index. (#370)#373

Merged
ti-chi-bot[bot] merged 5 commits intotikv:tikv-6.5from
LykxSassinator:cp_bugfix_6.5
Nov 8, 2024
Merged

[Cherry-pick] Fix panics on reading entries by stale index. (#370)#373
ti-chi-bot[bot] merged 5 commits intotikv:tikv-6.5from
LykxSassinator:cp_bugfix_6.5

Conversation

@LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Nov 7, 2024

Manual cp #370 to tikv-6.5 branch.

@LykxSassinator
Fix panics on reading entries by stale index. (tikv#370)
a487e4e 
 

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 7, 2024
@LykxSassinator
Fix CI.
61fa0e8 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 7, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 8, 2024
@LykxSassinator
Fix ci.
82bffeb 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot removed the lgtm label Nov 8, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-07 14:57:00.921592715 +0000 UTC m=+1139333.760748254: ☑️ agreed by Connor1996.
  • 2024-11-08 01:56:36.0278935 +0000 UTC m=+1178908.867049051: ☑️ agreed by overvenus.
  • 2024-11-08 03:02:28.320841069 +0000 UTC m=+1182861.159996615: ✖️🔁 reset by LykxSassinator.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 8, 2024

New changes are detected. LGTM label has been removed.

@LykxSassinator
Fix CI.
cc2e9e1 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Fix clippy errs.
2f0d630 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Copy link
Contributor Author

LykxSassinator commented Nov 8, 2024

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Connor1996, LykxSassinator, overvenus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Connor1996,LykxSassinator,overvenus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot added the lgtm label Nov 8, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 8, 2024

@LykxSassinator: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
rust-nightly 2f0d630 link unknown /test rust-nightly

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 2a4faff into tikv:tikv-6.5 Nov 8, 2024
@LykxSassinator LykxSassinator deleted the cp_bugfix_6.5 branch November 8, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overvenus overvenus overvenus approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LykxSassinator @overvenus @Connor1996 @ti-chi-bot