Skip to content

schedule: fix location label in placement rule not work well with rul…#6648

Merged
rleungx merged 3 commits intotikv:release-6.5-20230620-v6.5.2from
rleungx:cherry-pick-6633
Jun 20, 2023
Merged

schedule: fix location label in placement rule not work well with rul…#6648
rleungx merged 3 commits intotikv:release-6.5-20230620-v6.5.2from
rleungx:cherry-pick-6633

Conversation

@rleungx
Copy link
Member

@rleungx rleungx commented Jun 20, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #6637

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

rleungx added 2 commits June 20, 2023 21:53
@rleungx
schedule: fix location label in placement rule not work well with rul…
674a34d 
…e checker (tikv#6633)

close tikv#6637

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
schedule: fix location label in placement rule not work well with rul…
5773fd3 
…e checker (tikv#6633)

close tikv#6637

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 20, 2023
@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and disksing June 20, 2023 13:58
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 20, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 20, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 20, 2023
@rleungx
Copy link
Member Author

rleungx commented Jun 20, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 5773fd3

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 20, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2023

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 20, 2023
@rleungx rleungx force-pushed the release-6.5-20230620-v6.5.2 branch from 674a34d to 206d412 Compare June 20, 2023 14:10
@rleungx
Copy link
Member Author

rleungx commented Jun 20, 2023

/run-unit-tests

@rleungx rleungx merged commit 614ecda into tikv:release-6.5-20230620-v6.5.2 Jun 20, 2023
@rleungx rleungx deleted the cherry-pick-6633 branch June 20, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@CabinfeverB CabinfeverB CabinfeverB approved these changes

@disksing disksing Awaiting requested review from disksing

@HunDunDM HunDunDM Awaiting requested review from HunDunDM

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rleungx @lhy1024 @CabinfeverB