Skip to content

schedule: fix location label in placement rule not work well with rule checker (#6633)#6641

Closed
ti-chi-bot wants to merge 1 commit intotikv:release-6.5from
ti-chi-bot:cherry-pick-6633-to-release-6.5
Closed

schedule: fix location label in placement rule not work well with rule checker (#6633)#6641
ti-chi-bot wants to merge 1 commit intotikv:release-6.5from
ti-chi-bot:cherry-pick-6633-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jun 20, 2023

This is an automated cherry-pick of #6633

What problem does this PR solve?

Issue Number: Close #6637

What is changed and how does it work?

This PR is going to use the region store as the source instead of rule stores.

Check List

Tests

  • Unit test

Release note

None.

@rleungx @ti-chi-bot
This is an automated cherry-pick of tikv#6633
6970cf0 
close tikv#6637

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 20, 2023
Merged
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jun 20, 2023
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and disksing June 20, 2023 08:37
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2023

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci/build 6970cf0 link true /test build

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JmPotato
Copy link
Member

JmPotato commented Jun 24, 2023

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2023
@JmPotato JmPotato closed this Jul 3, 2023
@JmPotato JmPotato deleted the cherry-pick-6633-to-release-6.5 branch July 3, 2023 06:54
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@disksing disksing Awaiting requested review from disksing

@JmPotato JmPotato Awaiting requested review from JmPotato

Assignees

@rleungx rleungx

Labels

cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @JmPotato @rleungx