Skip to content

api: using index to replace tree scan if only returns count (#5610)#5651

Merged
ti-chi-bot merged 2 commits intotikv:release-6.1from
ti-chi-bot:cherry-pick-5610-to-release-6.1
Nov 1, 2022
Merged

api: using index to replace tree scan if only returns count (#5610)#5651
ti-chi-bot merged 2 commits intotikv:release-6.1from
ti-chi-bot:cherry-pick-5610-to-release-6.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Oct 28, 2022

This is an automated cherry-pick of #5610

What problem does this PR solve?

Issue Number: Close #5607

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

Release note

 None.

@bufferflies @ti-chi-bot
This is an automated cherry-pick of tikv#5610
c1dc3fc 
close tikv#5607

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Oct 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Oct 28, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 28, 2022
Merged
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. label Oct 28, 2022
@bufferflies
resolve confict
f89cbee 
Signed-off-by: bufferflies <1045931706@qq.com>
@bufferflies bufferflies force-pushed the cherry-pick-5610-to-release-6.1 branch from 0d910f2 to f89cbee Compare October 28, 2022 07:53
@codecov
Copy link

codecov bot commented Oct 28, 2022 •
edited
Loading

Codecov Report

Base: 75.58% // Head: 75.58% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (f89cbee) compared to base (90fe355).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff              @@
##           release-6.1    #5651   +/-   ##
============================================
  Coverage        75.58%   75.58%           
============================================
  Files              307      307           
  Lines            30397    30419   +22     
============================================
+ Hits             22975    22993   +18     
  Misses            5438     5438           
- Partials          1984     1988    +4
Flag Coverage Δ
unittests 75.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/api/stats.go 100.00% <100.00%> (ø)
server/cluster/cluster.go 84.07% <100.00%> (+0.95%) ⬆️
server/core/basic_cluster.go 91.41% <100.00%> (+0.13%) ⬆️
server/core/region.go 91.46% <100.00%> (+0.19%) ⬆️
server/tso/allocator_manager.go 64.22% <0.00%> (-3.83%) ⬇️
server/member/member.go 62.10% <0.00%> (-3.69%) ⬇️
server/schedule/labeler/rules.go 87.50% <0.00%> (-2.28%) ⬇️
server/election/lease.go 84.05% <0.00%> (-1.45%) ⬇️
tools/pd-ctl/pdctl/command/operator.go 66.66% <0.00%> (-1.15%) ⬇️
server/schedule/operator/step.go 74.74% <0.00%> (-1.02%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 31, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 1, 2022
@nolouch
Copy link
Contributor

nolouch commented Nov 1, 2022

PTAL @bufferflies

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 1, 2022
@bufferflies
Copy link
Contributor

bufferflies commented Nov 1, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Nov 1, 2022

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Nov 1, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: f89cbee

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 1, 2022
@ti-chi-bot ti-chi-bot merged commit 7d3c8a1 into tikv:release-6.1 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nolouch nolouch nolouch approved these changes

@bufferflies bufferflies bufferflies approved these changes

@HunDunDM HunDunDM Awaiting requested review from HunDunDM

@rleungx rleungx Awaiting requested review from rleungx

Assignees

@bufferflies bufferflies

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @nolouch @bufferflies @VelocityLight