client: check the timeout for creating stream (#2616)#2648
Merged
disksing merged 1 commit intotikv:release-4.0from Jul 15, 2020
Merged
client: check the timeout for creating stream (#2616)#2648disksing merged 1 commit intotikv:release-4.0from
disksing merged 1 commit intotikv:release-4.0from
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
disksing
approved these changes
Jul 15, 2020
Contributor
|
/merge |
Contributor
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2648 +/- ##
===============================================
- Coverage 77.14% 77.06% -0.09%
===============================================
Files 205 205
Lines 22173 22185 +12
===============================================
- Hits 17105 17096 -9
- Misses 3765 3782 +17
- Partials 1303 1307 +4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
cherry-pick #2616.
What is changed and how it works?
This PR uses an extra goroutine to check if creating stream causes too much time and will call cancel once it reaches the timeout setting of the client.
Release note