use leader read when tryFollower is fallback from accessKnownLeader#952
Merged
cfzjywxk merged 2 commits intotikv:masterfrom Aug 22, 2023
Merged
use leader read when tryFollower is fallback from accessKnownLeader#952cfzjywxk merged 2 commits intotikv:masterfrom
tryFollower is fallback from accessKnownLeader#952cfzjywxk merged 2 commits intotikv:masterfrom
Conversation
Signed-off-by: you06 <you1474600@gmail.com>
crazycs520
approved these changes
Aug 22, 2023
Contributor
cfzjywxk
reviewed
Aug 22, 2023
Signed-off-by: you06 <you1474600@gmail.com>
zyguan
approved these changes
Aug 22, 2023
cfzjywxk
approved these changes
Aug 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, we made some changes to the selector states, the
tryFolloweris not only used as a fallback state ofaccessKnownLeader, this PR keeps the compatibility oftryFollower's requests.Before the changes we made:
accessKnownLeader->tryFollower-> switch leader when success, and the flagKVContext.ReplicaReadis always false here.Now there is another path lead to
tryFollowerstate:accessFollower->tryFollower, in this case,KVContext.ReplicaReadis set to true intryFollowerstate.To make the behavior compatible with earlier versions, we need to set a flag for the
accessKnownLeader->tryFollowerpath, and that'sfromKnownLeader. It's renamed fromfromOnNotLeaderfor better semantic.cc @crazycs520