log: group replica selector logging and split not leader errors#929
Merged
cfzjywxk merged 2 commits intotikv:masterfrom Aug 24, 2023
Merged
log: group replica selector logging and split not leader errors#929cfzjywxk merged 2 commits intotikv:masterfrom
cfzjywxk merged 2 commits intotikv:masterfrom
Conversation
Contributor
Author
|
/cc @crazycs520 PTAL |
ekexium
reviewed
Aug 11, 2023
internal/locate/region_request.go
Outdated
| replica.store.storeID, | ||
| replica.isEpochStale(), | ||
| replica.attempts, | ||
| replica.epoch, |
Contributor
There was a problem hiding this comment.
Do we need to use atomic load on this variable?
Contributor
Author
There was a problem hiding this comment.
Thanks for the reminder. I understand the replica should not be used concurrently as its lifetime is the same as the replicaSelector, but I forget why atomic operations are used for the epoch updating.
557c9e6 to
826a612
Compare
ekexium
approved these changes
Aug 11, 2023
you06
approved these changes
Aug 18, 2023
| } | ||
| } | ||
|
|
||
| func (s *testRegionRequestToThreeStoresSuite) TestLogging() { |
Signed-off-by: cfzjywxk <lsswxrxr@163.com>
Signed-off-by: cfzjywxk <lsswxrxr@163.com>
826a612 to
9f88a2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RegionRequestSenderandreplicaSelector.totalErrosinto details forNotLeadererror responses,from