Replace stale-read traffic with local-remote traffic#877
Closed
you06 wants to merge 3 commits intotikv:tidb-6.5from
Closed
Replace stale-read traffic with local-remote traffic#877you06 wants to merge 3 commits intotikv:tidb-6.5from
you06 wants to merge 3 commits intotikv:tidb-6.5from
Conversation
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
Contributor
|
@crazycs520 PTAL |
Contributor
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By recording stale-read-miss traffic, we can know the traffic of remote reading.
But in some cases, the replica selector just skip the unavailable local replica and do a remote stale read. Even such stale-read is successful, billed traffic may be produced and need to be specified.
This PR will record the traffic of stale-read requests by local and remote types when there is labels. In the example metrics, the local store is in restart progress, but the stale-read success rate is still high, and we can find the remote traffic with this PR.