reload region cache when store is resolved from invalid status (#843)#846
Merged
cfzjywxk merged 12 commits intotikv:tidb-6.5from Jun 28, 2023
Merged
reload region cache when store is resolved from invalid status (#843)#846cfzjywxk merged 12 commits intotikv:tidb-6.5from
cfzjywxk merged 12 commits intotikv:tidb-6.5from
Conversation
Collaborator
|
cannot build. |
Contributor
Author
|
Hold this PR because it may spawns too many goroutines. |
Contributor
|
See the discussions in #843.
|
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: Smityz <smityz@qq.com> Co-authored-by: disksing <i@disksing.com> Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: disksing <i@disksing.com> Signed-off-by: you06 <you1474600@gmail.com>
d8bd792 to
3b066b5
Compare
cfzjywxk
reviewed
Jun 27, 2023
| mockRequestLiveness atomic.Value | ||
| } | ||
|
|
||
| regionsNeedReload struct { |
Contributor
There was a problem hiding this comment.
How about using a channel so Mutex could be saved and operations on the RegionCache are already synchronized?
Contributor
Author
There was a problem hiding this comment.
A channel is bounded, if it's full when trying scheduling a region to it, it'll wait(maybe the asyncCheckAndResolveLoop is doing something and cannot pull the channel immediately).
crazycs520
reviewed
Jun 27, 2023
crazycs520
reviewed
Jun 27, 2023
crazycs520
reviewed
Jun 27, 2023
crazycs520
reviewed
Jun 27, 2023
internal/locate/region_cache.go
Outdated
Comment on lines
+485
to
+488
| for regionID := range c.regionsNeedReload.toReload { | ||
| c.reloadRegion(regionID) | ||
| delete(c.regionsNeedReload.toReload, regionID) | ||
| } |
Contributor
There was a problem hiding this comment.
Look like those codes should be put after line #498 ?
Contributor
Author
There was a problem hiding this comment.
Delay the reload to next loop which avoids some errors and backoffs, see the comment of Line491 to Line494
Co-authored-by: crazycs <crazycs520@gmail.com> Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
3d629f8 to
98e21b3
Compare
Signed-off-by: you06 <you1474600@gmail.com>
cfzjywxk
approved these changes
Jun 28, 2023
| // insertRegionToCache tries to insert the Region to cache. | ||
| // It should be protected by c.mu.Lock(). | ||
| func (c *RegionCache) insertRegionToCache(cachedRegion *Region) { | ||
| func (c *RegionCache) insertRegionToCache(cachedRegion *Region, invalidateOldRegion bool) { |
Contributor
There was a problem hiding this comment.
Need to comment about the new parameter.
Contributor
Author
|
What's wrong with golangci-lint 🤔️ |
Contributor
|
@crazycs520 @ekexium @zyguan |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick #843 to tidb-6.5.